Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.9-dev: Upgrade setuptools #4784

Merged
merged 5 commits into from
Aug 13, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 13, 2020

The setuptools fix pypa/setuptools#2249 for #4769 has been released in setuptools v49.1.3, so we can require that version or newer.

Created as draft as there are further build problems from new changes in setuptools, will add comments.

@hugovk
Copy link
Member Author

hugovk commented Jul 13, 2020

The newest setuptools v49.2.0 warns:

/home/travis/virtualenv/python3.9-dev/lib/python3.9/site-packages/setuptools/distutils_patch.py:25: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.

(From pypa/setuptools#2256 / pypa/setuptools#2230)

And results in a build error:

/home/travis/virtualenv/python3.9-dev/lib/python3.9/site-packages/Pillow-7.3.0.dev0-py3.9-linux-x86_64.egg/PIL/Image.py:115: RuntimeWarning: The _imaging extension was built for another version of Pillow or PIL:
Core version: None
Pillow version: 7.3.0.dev0

https://travis-ci.org/github/hugovk/Pillow/jobs/707725016


Importing setuptools before distuils in setup.py gets rid of the warning but not the build error:

master...hugovk:3.9-upgrade-setuptools2

https://travis-ci.org/github/hugovk/Pillow/builds/707729489


And upgrading setuptools for all Python versions on Travis also has the same build error (not tested on Mac/Windows/other CIs):

master...hugovk:3.9-upgrade-setuptools3

https://travis-ci.org/github/hugovk/Pillow/builds/707730154


Will report to setuptools, and they're already reconsidering the strategy: pypa/setuptools#2259.

@hugovk
Copy link
Member Author

hugovk commented Jul 13, 2020

Reported: pypa/setuptools#2261.

@hugovk
Copy link
Member Author

hugovk commented Jul 13, 2020

Also macOS (and Linux) on GHA:

(Not Windows, but I've not checked it actually upgraded.)

@nulano
Copy link
Contributor

nulano commented Jul 13, 2020

(Not Windows, but I've not checked it actually upgraded.)

You only updated the MSYS script, and that build (surprisingly) passes with 49.1.3.

I added the upgrade to the main Windows build and it also fails:

@radarhere
Copy link
Member

I've concluded that this error was also introduced in setuptools 47.3.2. I've created pypa/setuptools#2297 to resolve.

@nulano nulano mentioned this pull request Aug 12, 2020
@hugovk
Copy link
Member Author

hugovk commented Aug 12, 2020

Hopefully this will pass now pypa/setuptools#2297 is merged and setuptools 49.3.2 is released 🤞

@hugovk hugovk marked this pull request as ready for review August 12, 2020 22:02
@nulano
Copy link
Contributor

nulano commented Aug 12, 2020

Just copying my comment from #4858: GHA 3.9-dev has been updated and now also has a broken setuptools version.

@hugovk hugovk changed the title Travis CI/3.9: Upgrade setuptools 3.9-dev: Upgrade setuptools Aug 13, 2020
@hugovk
Copy link
Member Author

hugovk commented Aug 13, 2020

Thanks, updated to upgrade on GHA for 3.9-dev as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants